zwoop commented on code in PR #11298: URL: https://github.com/apache/trafficserver/pull/11298#discussion_r1590457903
########## src/proxy/http2/HPACK.cc: ########## @@ -208,7 +211,7 @@ hpack_field_is_literal(HpackField ftype) // Try not to use memcmp(sv, sv) and strncasecmp(sv, sv) because we don't care which value comes first on a dictionary. // Return immediately if the lengths of given strings don't match. // Also, we noticed with profiling that taking char* and int was more performant than taking std::string_view. -static inline bool Review Comment: Poor static. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
