freak82 commented on PR #11357: URL: https://github.com/apache/trafficserver/pull/11357#issuecomment-2112848083
Hmm, I built all of the plugins and there was no other complains from GCC 13.2 on Debian. I can see that the `s3_auth` plugin has been built. It has not been skipped. Most likely this is due to different GCC versions. It seems to me that in the `plugins/s3_auth/s3_auth.cc ` the GCC analyzer is wrong about this warning: It most likely get confused from this usage `str_concat(&left[loff], (left_size - loff), "/", 1);` and because in the `str_concat` there is `std::min(dst_len, src_len)` for the `strncat` size argument. Maybe it'll be better if I change all of the remaining 5 usages of `strncat` in ``` plugins/s3_auth/s3_auth.cc (1) plugins/experimental/url_sig/url_sig.cc (4) ``` with `ink_strlcat`? Or the suppression can be left as it is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
