mattyw commented on code in PR #11414:
URL: https://github.com/apache/trafficserver/pull/11414#discussion_r1626141083
##########
tests/gold_tests/remap/remap_acl.test.py:
##########
@@ -296,3 +309,12 @@ def _configure_client(self, tr: 'TestRun') -> None:
acl_configuration='@action=allow @in_ip=3.4.5.6 @method=GET @method=POST',
named_acls=[],
expected_responses=[200, 403, 403, 403, 403])
+
+test_named_acl_deny = Test_remap_acl(
+ "Verify we can deny all but allow in a named acl.",
+ replay_file='get_head_post.replay.yaml',
+ ip_allow_content=IP_ALLOW_MINIMUM,
+ deactivate_ip_allow=False,
+ acl_configuration='',
+ named_acls=[('deny', '@action=deny @method=HEAD @method=POST')],
+ expected_responses=[200, 403, 403])
Review Comment:
@bneradt It's not clear to me what adding a `PUSH` would prove that isn't
already proven by the existing methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
