JosiahWI commented on code in PR #11424: URL: https://github.com/apache/trafficserver/pull/11424#discussion_r1631494871
########## plugins/ja3_fingerprint/ja3_fingerprint.cc: ########## @@ -126,52 +94,43 @@ getIP(sockaddr const *s_sockaddr, char res[INET6_ADDRSTRLEN]) } static std::string -custom_get_ja3(SSL *s) +custom_get_ja3(SSL *ssl) Review Comment: The APIs take them non-const. This is indeed a shame. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
