ywkaras commented on PR #11437:
URL: https://github.com/apache/trafficserver/pull/11437#issuecomment-2161099131
DM from zwoop:
it seems in other places where there’s not room, we do no truncate, rather,
we just don’t put anything in there. And we certainly never call
SiteThrottledError(), that just seems wrong honestly (from what I can tell,
SiteThrottledError() is for serious errors around logging completely, disk full)
So, I just wouldn’t produce an error here at all
(A Dbg() would be more appropriate I think)
I’m ok leaving teh truncation if that’s what you prefer
Looking more, if you really want a message here, maybe like this:
if (res < 0) {
SiteThrottledNote("%s", buffer_size_exceeded_msg);
(these are incredibly sparsely used though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
