maskit commented on code in PR #11490:
URL: https://github.com/apache/trafficserver/pull/11490#discussion_r1662956475
##########
src/iocore/net/QUICNetVConnection.cc:
##########
@@ -645,8 +645,8 @@ QUICNetVConnection::_handle_read_ready()
QUICConVDebug("stream %" PRIu64 " is readable\n", s);
QUICStream *stream = static_cast<QUICStream
*>(this->_stream_manager->find_stream(s));
if (stream == nullptr) {
- this->_stream_manager->create_stream(s);
- stream = static_cast<QUICStream
*>(this->_stream_manager->find_stream(s));
+ [[maybe_unused]] QUICConnectionError err;
Review Comment:
Oh, I didn't mean we should keep the original API. I was just telling the
background. The only debatable point would be which should be the return type
of create_stream, the error or the stream. But it's not a huge deal. I'm fine
with the current API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
