vmamidi commented on code in PR #11557:
URL: https://github.com/apache/trafficserver/pull/11557#discussion_r1688227005
##########
src/proxy/http/HttpSM.cc:
##########
@@ -1131,17 +1131,13 @@ HttpSM::state_request_wait_for_transform_read(int
event, void *data)
// data as well as fix up the request header
t_state.hdr_info.transform_request_cl = size;
t_state.hdr_info.server_request.value_set_int64(MIME_FIELD_CONTENT_LENGTH,
MIME_LEN_CONTENT_LENGTH, size);
- setup_server_send_request_api();
- break;
- } else {
- // No content length from the post. This is a no go
- // since http spec requires content length when
- // sending a request message body. Change the event
- // to an error and fall through
- event = VC_EVENT_ERROR;
- Log::error("Request transformation failed to set content length");
}
- // FALLTHROUGH
+ // If the post body is more than one packet, we may not have the total
body size set.
+ // Continue on with the transform_request_cl set to the default value of
-1. If the transform
+ // changes the content lenght of the post body, the data argument must be
specified even after
+ // the first packet
+ setup_server_send_request_api();
Review Comment:
I think we shouldn't do POST transformation if we do not have TE/CL headers
for POST request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
