ywkaras commented on code in PR #11653:
URL: https://github.com/apache/trafficserver/pull/11653#discussion_r1705705978
##########
plugins/header_rewrite/header_rewrite.cc:
##########
@@ -523,6 +548,8 @@ TSRemapDoRemap(void *ih, TSHttpTxn rh, TSRemapRequestInfo
*rri)
if (rule->eval(res)) {
OperModifiers rt = rule->exec(res);
+ ink_assert((rt & OPER_NO_REENABLE) == 0);
Review Comment:
Generally speaking, ink_assert() should not be used in plugin code. But,
since header_rewrite already include core ATS headers, go with the flow I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
