sharkleash commented on PR #11659:
URL: https://github.com/apache/trafficserver/pull/11659#issuecomment-2285045010
Thanks for finding this, would the behavior be the same in this case? It is
definitely a bug that additional_accepts isn't a signed int, but doesn't
setting an unsigned int to -1, make it equal to 2^32 - 1 (INT32_MAX - 1)? In
that case, there's a section of code in NetHandler.cc that adds 1 to that,
making it overflow to 0, and then sets it to 2^32 - 1 anyway.
this is that code:
`int config_value = additional_accepts.load(std::memory_order_relaxed) + 1;
return (config_value > 0 ? config_value : INT32_MAX - 1);`
It's certainly a bug, but if the behavior is the same, maybe this doesn't
need to go into 10.0.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
