masaori335 commented on code in PR #11737:
URL: https://github.com/apache/trafficserver/pull/11737#discussion_r1732160730
##########
src/iocore/cache/StripeSM.h:
##########
@@ -65,6 +65,8 @@ class StripeSM : public Continuation, public Stripe
{
public:
CryptoHash hash_id;
+ char *path = nullptr;
+ int fd{-1};
Review Comment:
`CacheDisk` has `path` and `fd`. I start wondering we should just refer them
instead of copy it because `StripeSM` has `CacheDisk *`.
https://github.com/apache/trafficserver/blob/d0b6a4b49ba8f2738fe91606c9cea55b06220cec/src/iocore/cache/P_CacheDisk.h#L86
https://github.com/apache/trafficserver/blob/d0b6a4b49ba8f2738fe91606c9cea55b06220cec/src/iocore/cache/Cache.cc#L291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
