maskit opened a new pull request, #11794: URL: https://github.com/apache/trafficserver/pull/11794
There are redundant wrapper functions in UnixNetVC and the design is inconstant between read and write, and also between UnixNetVC and SSLNetVC. This PR is a first step for further refactoring/abstraction. It removes those redundant functions and aligns the design. I also removed a few parameters that don't need to be passed around. There should be no change in the flow. With this change, we should be able to move the TLS related code into SSLNetVC from UnixNetVC like `load_buffer_and_write`. Before UnixNetVConnection ``` UnixNetVConnection::net_read_io -> ::read_from_net UnixNetVConnection::net_write_io -> ::write_to_net -> ::write_to_net_io -> UnixNetVConnection::load_buffer_and_write UnixNetVConnection::netActivity -> ::net_activity ``` SSLNetVConnection ``` SSLNetVConnection::net_read_io UnixNetVConnection::net_write_io -> ::write_to_net -> ::write_to_net_io -> SSLNetVConnection::load_buffer_and_write ``` After UnixNetVConnection ``` UnixNetVConnection::net_read_io UnixNetVConnection::net_write_io -> UnixNetVConnection::load_buffer_and_write UnixNetVConnection::netActivity ``` SSLNetVConnection ``` SSLNetVConnection::net_read_io UnixNetVConnection::net_write_io -> SSLNetVConnection::load_buffer_and_write ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
