brbzull0 commented on PR #11815: URL: https://github.com/apache/trafficserver/pull/11815#issuecomment-2429348505
> I am not sure this is correct. Should you call read_ready if there were some bytes read in previous iterations of the outer loop? Shouldn't a timeout from read_ready stop the inner loop? It seems like this will always wait until EOF or until (timeout_ms * attempts) have elapsed. The logic is a bit confusing, so maybe some comments about what is happening will clear it up. Hi. It was weird indeed 🤮 I changed it a bit now, single loop, check for the data in the socket, if available we read, if not we wait a few times unless an error occurs. Should be simpler now. side note: I am planning to clean up this in a future PR, some of the `ReadError` makes no more sense since we changed the buffer approach few months back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
