tlichwala commented on code in PR #11871: URL: https://github.com/apache/trafficserver/pull/11871#discussion_r1869072332
########## include/tscore/ink_thread.h: ########## @@ -30,7 +30,15 @@ #include "tscore/ink_hrtime.h" #include "tscore/ink_defs.h" +#ifndef _GNU_SOURCE +#define _GNU_SOURCE +#endif #include <sched.h> +#if TS_USE_HWLOC +#include <hwloc.h> +#include <hwloc/glibc-sched.h> Review Comment: I am unable to reproduce the compilation error that occurs when including the header file <hwloc/glibc-sched.h> on freebsd. The error message is: "Please make sure to include sched.h before including glibc-sched.h, and define _GNU_SOURCE before any inclusion of sched.h". I added the undesirable definition of the _GNU_SOURCE macro in the code, as shown below, to ensure that it is defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
