brbzull0 commented on PR #11902: URL: https://github.com/apache/trafficserver/pull/11902#issuecomment-2535288255
[Implementation](https://github.com/apache/trafficserver/blob/master/src/records/RecordsConfig.cc#L1171C18-L1171C54) seems fine, at least it follows what was the logic when this fields were [renamed](https://github.com/apache/trafficserver/pull/9264): ``` Naming Changes: All these renamed records are subject to the following reasoning: If a value is meant to be used as a toggle on/off, I’ve used the name enabled. If a value is meant to be used as an enumeration, I’ve used the name value ``` So `proxy.config.ssl.origin_session_cache.enabled` and `proxy.config.ssl.session_cache.value` were renamed base on the above but documentation wasn't properly updated. I do agree that `mode` is more appropriate than `value`, but seems late to make this ammend. [This](https://github.com/apache/trafficserver/blob/master/doc/release-notes/upgrading.en.rst?plain=1#L175) needs to be updated too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
