masaori335 commented on code in PR #11927: URL: https://github.com/apache/trafficserver/pull/11927#discussion_r1908201341
########## doc/admin-guide/plugins/compress.en.rst: ########## @@ -107,7 +107,9 @@ range-request ------------- When set to ``true``, causes |TS| to compress responses to Range Requests. -Disabled by default. Setting this to true while setting cache to false leads to delivering corrupted content. +Disabled by default. + +WARNING! Do NOT set this to true if cache is set to false. This combination will deliver corrupt content. Review Comment: This `cache` here is a configuration of compress plugin. https://docs.trafficserver.apache.org/en/10.0.x/admin-guide/plugins/compress.en.html#cache Config like below generates corrupted content. ( compressed partial content with status code 200 OK ) ``` cache false range-request true ``` Also, I want to mention a thing, even if this `cache` config is `true`, and `range-request` is `false` like below, ``` cache true range-request false ``` once compressed content is cached, response to the Range request will be "partial content of compressed contents". IMO, if a client send both of `Accept-Encoding` and `Range` header, we should choose one of them as a workaround. ( I'll file an issue and PR for this ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
