cmcfarlen commented on code in PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#discussion_r1909525637


##########
lib/swoc/include/swoc/bwf_base.h:
##########
@@ -467,7 +467,7 @@ template <typename T> class ContextNames : public 
NameMap<BufferWriter &(BufferW
  * This nameset is used if no other is provided. Therefore bindings added to 
this nameset will be
  * available in the default formatting use.
  */
-extern ExternalNames Global_Names;
+extern ExternalNames& Global_Names();

Review Comment:
   You can drop `extern` here since its a function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to