bneradt commented on code in PR #11951:
URL: https://github.com/apache/trafficserver/pull/11951#discussion_r1915205598
##########
src/proxy/http/remap/RemapConfig.cc:
##########
@@ -100,6 +97,14 @@ BUILD_TABLE_INFO::BUILD_TABLE_INFO()
BUILD_TABLE_INFO::~BUILD_TABLE_INFO()
{
this->reset();
+
+ // clean up any leftover named filter rules
+ auto *rp = rules_list;
+ while (rp != nullptr) {
+ auto *tmp = rp->next;
+ delete rp;
+ rp = tmp;
+ }
Review Comment:
Awesome.
Let's not do this in this PR because what you're doing here with delete
appropriately fits the current setup, but it would be good to change these over
to shared_ptrs. (I think they are shared across rules so unique_ptr won't
work?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
