shukitchan commented on code in PR #11963:
URL: https://github.com/apache/trafficserver/pull/11963#discussion_r1919285797


##########
plugins/lua/ts_lua_client_request.c:
##########
@@ -399,6 +403,65 @@ ts_lua_client_request_get_headers(lua_State *L)
   return 1;
 }
 
+static int
+ts_lua_client_request_get_header_block(lua_State *L)
+{
+  TSIOBuffer       output_buffer;
+  TSIOBufferReader reader;
+  int              total_avail;
+
+  TSIOBufferBlock block;
+  const char     *block_start;
+  int64_t         block_avail;
+
+  char   *output_string;
+  int64_t output_len;
+
+  ts_lua_http_ctx *http_ctx;
+
+  GET_HTTP_CONTEXT(http_ctx, L);
+
+  output_buffer = TSIOBufferCreate();
+  reader        = TSIOBufferReaderAlloc(output_buffer);
+
+  TSMimeHdrPrint(http_ctx->client_request_hdrp, output_buffer);

Review Comment:
   Signature changed between 9.x and 10.x
   
   TSMimeHdrPrint(http_ctx->client_request_bufp, http_ctx->client_request_hdrp, 
output_buffer);
   
   



##########
plugins/lua/ts_lua_client_request.c:
##########
@@ -399,6 +403,65 @@ ts_lua_client_request_get_headers(lua_State *L)
   return 1;
 }
 
+static int
+ts_lua_client_request_get_header_block(lua_State *L)
+{
+  TSIOBuffer       output_buffer;
+  TSIOBufferReader reader;
+  int              total_avail;
+
+  TSIOBufferBlock block;
+  const char     *block_start;
+  int64_t         block_avail;
+
+  char   *output_string;
+  int64_t output_len;
+
+  ts_lua_http_ctx *http_ctx;
+
+  GET_HTTP_CONTEXT(http_ctx, L);
+
+  output_buffer = TSIOBufferCreate();
+  reader        = TSIOBufferReaderAlloc(output_buffer);
+
+  TSMimeHdrPrint(http_ctx->client_request_hdrp, output_buffer);
+
+  total_avail = TSIOBufferReaderAvail(reader);
+
+  output_string = static_cast<char *>(TSmalloc(total_avail + 1));

Review Comment:
   we also moved from c to cc
   so some syntax is to be different 
   
    output_string = (char *)TSmalloc(total_avail + 1);



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to