maskit commented on code in PR #11983:
URL: https://github.com/apache/trafficserver/pull/11983#discussion_r1929393395
##########
tests/gold_tests/tls/test-0rtt-s_client.py:
##########
@@ -22,25 +22,40 @@
import os
import shlex
import h2_early_decode
+import argparse
def main():
- ats_port = sys.argv[1]
- http_ver = sys.argv[2]
- test = sys.argv[3]
- sess_file_path = os.path.join(sys.argv[4], 'sess.dat')
- early_data_file_path = os.path.join(sys.argv[4],
'early_{0}_{1}.txt'.format(http_ver, test))
+ parser = argparse.ArgumentParser(description='Process some args.')
+ parser.add_argument('-p', '--ats-port', type=int, dest='ats_port',
required=True, help='ATS port number')
Review Comment:
The caller side (tls_0rtt_server.test.py) needs to be updated to use this.
https://github.com/apache/trafficserver/pull/9741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
