maskit commented on code in PR #12110:
URL: https://github.com/apache/trafficserver/pull/12110#discussion_r2004389413


##########
src/iocore/net/YamlSNIConfig.cc:
##########
@@ -442,6 +452,12 @@ template <> struct convert<YamlSNIConfig::Item> {
     if (node[TS_client_sni_policy]) {
       item.client_sni_policy = node[TS_client_sni_policy].as<std::string>();
     }
+    if (node[TS_server_cipher_suite]) {
+      item.server_cipher_suite = 
node[TS_server_cipher_suite].as<std::string>();
+    }
+    if (node[TS_server_TLSv1_3_cipher_suites]) {

Review Comment:
   I thought this would cause a compile error but I was wrong. `TSDECL` 
declares the name regardless of the availability, so we can have this without 
the check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to