JosiahWI commented on code in PR #12127:
URL: https://github.com/apache/trafficserver/pull/12127#discussion_r2013099145


##########
src/iocore/cache/StripeSM.cc:
##########
@@ -117,7 +117,7 @@ StripeSM::StripeSM(CacheDisk *disk, off_t blocks, off_t 
dir_skip, int avg_obj_si
     Stripe{disk, blocks, dir_skip, avg_obj_size, fragment_size},
     fd{disk->fd},
     disk{disk},
-    _preserved_dirs{static_cast<int>(len)}
+    _preserved_dirs{len}

Review Comment:
   I could also look at how big a change it would be to make the table size an 
`off_t` type, but I need to be careful because I don't understand yet why they 
were different in the first place. It seems like using the same type for both 
would be more consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to