cmcfarlen commented on code in PR #12144: URL: https://github.com/apache/trafficserver/pull/12144#discussion_r2021848203
########## src/proxy/http/HttpConfig.cc: ########## @@ -1080,6 +1080,7 @@ HttpConfig::reconfigure() params->outbound = m_master.outbound; + ats_free(params->proxy_hostname); Review Comment: The `params` variable is allocated with `new` on line 1077, so all of these pointers should not have anything assigned to them. We discussed this at the review meeting and think this change is not necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
