bneradt commented on code in PR #12032:
URL: https://github.com/apache/trafficserver/pull/12032#discussion_r2021867342


##########
include/ts/ts.h:
##########
@@ -3077,3 +3077,28 @@ TSRalloc(size_t count = 1 /**< Number of instances of T 
to allocate storage for.
 {
   return static_cast<std::remove_cv_t<T> *>(TSmalloc(count * sizeof(T)));
 }
+
+/**
+   Return the particular PROXY protocol info requested.
+
+   @param vconn the vconection pointer
+   @param key the requested PROXY protocol info. One of TSVConnPPInfoKey or 
TLV type ID
+   @param value a pointer to a const char pointer where the return value is 
stored
+   @param length a pointer to a integer where the length of return value is 
stored
+
+   @return @c TS_SUCCESS if the requested info is supported, TS_ERROR otherwise
+
+*/
+TSReturnCode TSVConnPPInfoGet(TSVConn vconn, uint16_t key, const char **value, 
int *length);
+
+/**
+   Return the particular PROXY protocol info requested.
+
+   @param vconn the vconection pointer
+   @param key the requested PROXY protocol info. One of TSVConnPPInfoKey or 
TLV type ID

Review Comment:
   This one has to be a `TSVConnPPInfoKey` value, right? Should it take a 
`TSVConnPPInfoKey` type rather than a `uint16_t`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to