bryancall commented on code in PR #12121:
URL: https://github.com/apache/trafficserver/pull/12121#discussion_r2028978473
##########
plugins/compress/configuration.cc:
##########
@@ -270,16 +270,22 @@ HostConfiguration::compression_algorithms()
return compression_algorithms_;
}
+/**
+ "true" and "false" are compatibility with old version, will be removed
+ */
void
HostConfiguration::set_range_request(const std::string &token)
{
- // "true" and "false" are compatibility with old version, will be removed
- if (token == "false" || token == "ignore-range") {
- range_request_ctl_ = RangeRequestCtrl::IGNORE_RANGE;
- } else if (token == "true" || token == "none") {
+ if (token == "true" || token == "none") {
range_request_ctl_ = RangeRequestCtrl::NONE;
- } else if (token == "no-compression") {
+ } else if (token == "false" || token == "no-compression") {
Review Comment:
Should you still support `ignore-range` for compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
