bryancall commented on code in PR #12125:
URL: https://github.com/apache/trafficserver/pull/12125#discussion_r2029001543


##########
doc/admin-guide/plugins/header_rewrite.en.rst:
##########
@@ -1073,6 +1073,22 @@ TXN_DEBUG        Enable transaction debugging (default: 
``off``)
 SKIP_REMAP       Don't require a remap match for the transaction (default: 
``off``)
 ================ 
====================================================================
 
+set-plugin-cntl
+~~~~~~~~~~~~~~~
+::
+
+  set-plugin-cntl <controller> <value>
+
+This operator lets you control the fundamental behavior of this plugin for a 
particular transaction.
+The available controllers are:
+
+================== ===================== 
=============================================================================================
+Controller         Operators/Conditions  Description
+================== ===================== 
=============================================================================================
+TIMEZONE           ``NOW``               If ``GMT`` is passed, the operators 
and conditions use GMT regardles of the timezone setting

Review Comment:
   NOW is not a valid timezone, maybe put `LOCAL` there instead?



##########
plugins/header_rewrite/operators.cc:
##########
@@ -1193,6 +1193,57 @@ OperatorSetHttpCntl::exec(const Resources &res) const
   return true;
 }
 
+void
+OperatorSetPluginCntl::initialize(Parser &p)
+{
+  Operator::initialize(p);
+  const std::string &name  = p.get_arg();
+  const std::string &value = p.get_value();
+
+  if (name == "TIMEZONE") {

Review Comment:
   `LOCAL` and `GMT` look like the only two possible values, should add that to 
the docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to