cmcfarlen commented on code in PR #12155:
URL: https://github.com/apache/trafficserver/pull/12155#discussion_r2029224303
##########
include/cripts/Connections.hpp:
##########
@@ -414,15 +434,16 @@ namespace Server
[[nodiscard]] int FD() const override;
[[nodiscard]] int Count() const override;
static Connection &_get(cripts::Context *context);
+ void _initialize() override;
void
- SetDscp(int val) override
+ SetDscp(int val) const override
{
TSHttpTxnServerPacketDscpSet(_state->txnp, val);
}
void
- SetMark(int val) override
+ SetMark(int val) const override
Review Comment:
Should these be const? It's mutating the txn...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
