bneradt commented on code in PR #12180:
URL: https://github.com/apache/trafficserver/pull/12180#discussion_r2040107694
##########
cmake/Findopentelemetry.cmake:
##########
@@ -118,5 +119,6 @@ if(opentelemetry_FOUND)
list(APPEND opentelemetry_LIBRARIES opentelemetry::${OTLIB})
endif()
endforeach()
+ target_compile_options(opentelemetry::opentelemetry_trace INTERFACE
-Wno-cpp)
Review Comment:
Yeah, I tested `opentelemetry::opentelemetry_trace` and that's not actually
defined for the non-Apple condition in here. But
`opentelemetry::opentelemetry_trace` does make the build happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
