bneradt commented on code in PR #12213:
URL: https://github.com/apache/trafficserver/pull/12213#discussion_r2059325560
##########
doc/admin-guide/plugins/header_rewrite.en.rst:
##########
@@ -752,8 +752,17 @@ OR Indicates that either the current condition or the
next one must be
true, as contrasted with the default behavior from ``[AND]``.
NOCASE Indicates that the string comparison, or regular expression, should be
case-insensitive. The default is to be case-sensitive.
+PRE Make a prefix match on a string comparison.
+SUF Make a suffix match on a string comparison.
+MID Make a substring match on a string comparison.
+EXT The substring match only applies to the file extension following a dot.
+ This is likely mostly useful for e.g. the ``URL:PATH`` part.
Review Comment:
I think the `for` and `e.g.` might be redundant. Maybe:
```
This is generally mostly useful for the ``URL:PATH`` part.
```
##########
plugins/header_rewrite/condition.cc:
##########
@@ -75,26 +75,50 @@ Condition::initialize(Parser &p)
if (p.mod_exist("AND")) {
TSError("[%s] Can't have both AND and OR in mods", PLUGIN_NAME);
} else {
- _mods = static_cast<CondModifiers>(_mods | COND_OR);
+ _mods = static_cast<CondModifiers>(_mods | CondModifiers::OR);
Review Comment:
Can these be `|=` as you did on line 93 too?
```cpp
_mods |= CondModifiers::OR;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
