Copilot commented on code in PR #12219:
URL: https://github.com/apache/trafficserver/pull/12219#discussion_r2071904922
##########
src/iocore/net/SSLSNIConfig.cc:
##########
@@ -231,23 +228,24 @@ SNIConfigParams::get(std::string_view servername,
in_port_t dest_incoming_port)
}
// Check for wildcard matches
- int ovector[OVECSIZE];
+ RegexMatches matches;
+ size_t *ovector = nullptr;
for (auto const &retval : sni_action_list) {
if (element != nullptr && element->rank < retval.rank) {
break;
}
- int length = servername.length();
- if (retval.match == nullptr && length == 0) {
+ size_t length = servername.length();
+ if (retval.match.empty() == true && length == 0) {
Review Comment:
[nitpick] Consider simplifying the boolean condition to 'if
(retval.match.empty() && length == 0)' to improve readability.
```suggestion
if (retval.match.empty() && length == 0) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
