cmcfarlen commented on code in PR #12222: URL: https://github.com/apache/trafficserver/pull/12222#discussion_r2076620625
########## plugins/experimental/wasm/CMakeLists.txt: ########## @@ -18,5 +18,28 @@ add_subdirectory(lib) add_atsplugin(wasm ats_context.cc ats_wasm.cc wasm_main.cc) -target_link_libraries(wasm PRIVATE wasmlib wamr::wamr) + +set(WASM_RUNTIME wasmlib) +if(wamr_FOUND) + list(APPEND WASM_RUNTIME wamr::wamr) +endif() +if(wasmtime_FOUND) + list(APPEND WASM_RUNTIME wasmtime::wasmtime) +endif() +if(wasmedge_FOUND) + list(APPEND WASM_RUNTIME wasmedge::wasmedge) +endif() Review Comment: If having multiple runtime included might be an issue, you could use else if to ensure only one. You'll have to pick some priorities to the libraries, but users could still select their preference with cmake directives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
