bneradt commented on code in PR #12226:
URL: https://github.com/apache/trafficserver/pull/12226#discussion_r2078239524
##########
plugins/experimental/memcache/tsmemcache.cc:
##########
@@ -249,7 +249,7 @@ MC::add_binary_header(uint16_t err, uint8_t hdr_len,
uint16_t key_len, uint32_t
int
MC::write_binary_error(protocol_binary_response_status err, int swallow)
{
- const char *errstr = "Unknown error";
+ const char *errstr;
Review Comment:
Let's initialize to `nullptr` while we're at it.
##########
src/iocore/net/UnixNetVConnection.cc:
##########
@@ -663,7 +663,7 @@ UnixNetVConnection::net_write_io(NetHandler *nh)
nh->write_ready_list.remove(this);
}
- int err, ret;
+ int err{0}, ret;
Review Comment:
Let's set `ret` to 0 as well.
##########
src/proxy/http/HttpTransact.cc:
##########
@@ -7527,9 +7527,9 @@ HttpTransact::handle_parent_down(State *s)
void
HttpTransact::handle_server_down(State *s)
{
- const char *reason = nullptr;
- const char *body_type = "UNKNOWN";
- HTTPStatus status = HTTP_STATUS_BAD_GATEWAY;
+ const char *reason = nullptr;
+ const char *body_type;
Review Comment:
`nullptr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
