mlibbey commented on PR #12241: URL: https://github.com/apache/trafficserver/pull/12241#issuecomment-2877456472
I think this is a compatible bug fix, as the current behavior covers the "riskier" cases, but not the "safer" cases -- the fix begins covering the safer case. Currently, the max_stale_age setting only applies to objects with shorter Cache-Control: max-age (aka ttl). The shorter the ttl, the larger the percentage of potential stale time. For instance, the default 7 day max_stale_age would be 700% of a 1 day ttl; and obviously grows the shorter the ttl. Conversely, the default is only 25% of a 1 month ttl and 2% of a 1 year percent. It's much safer to allow an object with 1yr ttl to be served an extra 2% than to allow an 1hr ttl object to be served for so long. (We should really have a percentage setting instead-- for instance setting stale to be 25% would allow a 1hr ttl object to be served stale for an extra 15 min, whereas a 1 month ttl object would be allowed to be served for an extra week.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
