bryancall commented on PR #12248: URL: https://github.com/apache/trafficserver/pull/12248#issuecomment-2887686767
Hey @masaori335, you added in the performance enhancements and ranking to begin with, so you should know more about this code than anyone else. Can you please review the bug fix and the added tests? If you can think of more tests I can add them too. I have another PR to change the PCRE regexes to use the `Regex` class (PCRE2 wrapper) and I want to make sure the tests will catch any new bugs. I have to check to see if we are covering case were we verify the capture group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
