bryancall commented on code in PR #12223:
URL: https://github.com/apache/trafficserver/pull/12223#discussion_r2103399328
##########
src/iocore/net/TLSBasicSupport.cc:
##########
@@ -185,6 +185,13 @@ TLSBasicSupport::set_cipher_suite([[maybe_unused]]
std::string const &cipher_sui
#endif
}
+void
+TLSBasicSupport::set_groups_list(std::string const &groups_list)
+{
+ auto ssl = this->_get_ssl_object();
+ SSL_set1_groups_list(ssl, groups_list.c_str());
Review Comment:
Shouldn't we check the return code? What happens if the group_list is
invalid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
