masaori335 commented on code in PR #12278:
URL: https://github.com/apache/trafficserver/pull/12278#discussion_r2137060494
##########
plugins/header_rewrite/operators.cc:
##########
@@ -343,6 +343,8 @@ OperatorSetDestination::exec(const Resources &res) const
TSMLoc new_url_loc;
if (TSUrlCreate(bufp, &new_url_loc) == TS_SUCCESS && TSUrlParse(bufp,
new_url_loc, &start, end) == TS_PARSE_DONE &&
TSHttpHdrUrlSet(bufp, res.hdr_loc, new_url_loc) == TS_SUCCESS) {
+ // This case creates a new_url_loc which should be used for any
other set-destination case
+ res._rri->requestUrl = reinterpret_cast<TSMLoc>(new_url_loc);
Review Comment:
It seems like we don't need this cast, because the `new_url_loc` is `TSMLoc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
