zwoop commented on code in PR #12286:
URL: https://github.com/apache/trafficserver/pull/12286#discussion_r2144096099
##########
tools/hrw4u/bootstrap.sh:
##########
@@ -20,12 +20,22 @@ set -e
VENV_NAME="hrw4u"
+if ! which antlr; then
Review Comment:
Does this work? Don't you have to put that into backticks or $() at least ?
##########
doc/admin-guide/configuration/hrw4u.en.rst:
##########
@@ -220,6 +225,13 @@ set-debug set-debug() Enables ATS
txn debug
skip-remap skip-remap() Skip remap processing (open
proxy)
================= ============================ ================================
+String concatenations
+---------------------
+
+You can concatenate values using strings, condition values and variable
expansions on the same line in
+operators using. For instance, `outbound.req.CustomHeader “Hello from
{inbound.ip}:{inbound.port}”`. As
+a result, the set-redirect's `[QSA]` flag would be implemented as
`set-redirect(302, "https://...{inbound.url.query}";)``
Review Comment:
Maybe make sure the ? is here? I'm not sure if ATS's query value includes
the ? or not... I want to say not but I can test tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
