masaori335 commented on code in PR #12284:
URL: https://github.com/apache/trafficserver/pull/12284#discussion_r2144414170


##########
include/ts/apidefs.h.in:
##########
@@ -985,6 +990,23 @@ using TSMgmtInt     = int64_t;
 using TSMgmtCounter = int64_t;
 using TSMgmtFloat   = float;
 using TSMgmtString  = char *;
+using TSMgmtSeconds = std::chrono::seconds;
+
+class HttpStatusCodeList;
+struct HostResData;
+class HttpForwardedConf;
+
+// clang-format off
+using TSConfigValue = std::variant<
+                        TSMgmtInt,
+                        TSMgmtFloat,
+                        TSMgmtSeconds,
+                        std::string_view,
+                        HttpStatusCodeList *,
+                        HostResData *,
+                        HttpForwardedConf *,
+                        TSOutboundConnectionMatchType>;

Review Comment:
   Now, this variant captures all types in the `OverridableHttpConfigParams`. 
However, as @zwoop pointed out, every time we add a new type here, ABI 
compatibility is broken 🤔



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to