bryancall commented on PR #12243:
URL: https://github.com/apache/trafficserver/pull/12243#issuecomment-2981790367
@hnakamur it looks like there are a couple minor errors from the recent CI
build. I have reviewed the code and it looks good besides these new issues:
```
In file included from ../src/iocore/cache/CacheEvacuateDocVC.cc:33:
../src/iocore/cache/P_CacheInternal.h:515:33: error: too many arguments to
function call, expected 0, have 1
key->hostname = url->host_get(&key->hostlen);
~~~~~~~~~~~~~ ^~~~~~~~~~~~~
../include/proxy/hdrs/URL.h:571:6: note: 'host_get' declared here
URL::host_get() const noexcept
^
In file included from ../src/iocore/cache/CacheEvacuateDocVC.cc:33:
../src/iocore/cache/P_CacheInternal.h:515:19: error: assigning to 'const
char *' from incompatible type 'std::string_view' (aka
'basic_string_view<char>')
key->hostname = url->host_get(&key->hostlen);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
```
```
../src/iocore/cache/P_CacheInternal.h:515:33: error: too many arguments to
function call, expected 0, have 1
key->hostname = url->host_get(&key->hostlen);
~~~~~~~~~~~~~ ^~~~~~~~~~~~~
../include/proxy/hdrs/URL.h:571:6: note: 'host_get' declared here
URL::host_get() const noexcept
^
In file included from ../src/iocore/cache/CacheDir.cc:27:
../src/iocore/cache/P_CacheInternal.h:515:19: error: assigning to 'const
char *' from incompatible type 'std::string_view' (aka
'basic_string_view<char>')
key->hostname = url->host_get(&key->hostlen);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
```
```
../src/iocore/cache/P_CacheInternal.h:515:33: error: too many arguments to
function call, expected 0, have 1
key->hostname = url->host_get(&key->hostlen);
~~~~~~~~~~~~~ ^~~~~~~~~~~~~
../include/proxy/hdrs/URL.h:571:6: note: 'host_get' declared here
URL::host_get() const noexcept
^
In file included from ../src/iocore/cache/CacheHttp.cc:25:
../src/iocore/cache/P_CacheInternal.h:515:19: error: assigning to 'const
char *' from incompatible type 'std::string_view' (aka
'basic_string_view<char>')
key->hostname = url->host_get(&key->hostlen);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
