moonchen commented on code in PR #12290:
URL: https://github.com/apache/trafficserver/pull/12290#discussion_r2164785266
##########
src/iocore/net/SSLNetVConnection.cc:
##########
@@ -433,6 +440,7 @@ SSLNetVConnection::update_rbio(bool move_to_socket)
char *start = this->handShakeReader->start();
char *end = this->handShakeReader->end();
Review Comment:
This will give the end of the current block, so the client hello must fit
within the first IO buffer block. The block size defaults to 32k bytes. We
should document this limitation and instruct the administrator to increase
`proxy.config.ssl.misc.io.max_buffer_index` when they want to accommodate
larger client hello messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
