bneradt commented on code in PR #12168:
URL: https://github.com/apache/trafficserver/pull/12168#discussion_r2175386407
##########
tests/gold_tests/basic/config.test.py:
##########
@@ -15,17 +15,18 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
+import os
Review Comment:
Is this needed?
##########
tests/gold_tests/basic/copy_config.test.py:
##########
@@ -15,18 +15,19 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
+import os
Review Comment:
Not needed? i don't see a reference to `os` in your new lines, but maybe my
eyes are missing it.
##########
tests/gold_tests/basic/copy_config.test.py:
##########
@@ -37,14 +38,14 @@
t = Test.AddTestRun("Talk to ts1")
t.Processes.Default.StartBefore(ts1)
t.Processes.Default.StartBefore(ts2)
-t.MakeCurlCommand("127.0.0.1:{port}".format(port=ts1.Variables.port))
+t.MakeCurlCommand("127.0.0.1:{port}".format(port=ts1.Variables.port),
uds_path=ts1.Variables.uds_path)
Review Comment:
I suggest passing ts rather than uds_path for each of these. That way the
user doesn't need to think of the uds_path for each of these tests (it's easier
just to pass ts) and if something else like this is overlaid in MakeCurlCommand
based on ts it can grab it from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
