cmcfarlen commented on code in PR #12307:
URL: https://github.com/apache/trafficserver/pull/12307#discussion_r2176082765
##########
plugins/origin_server_auth/origin_server_auth.cc:
##########
@@ -1269,11 +1276,18 @@ TSRemapNewInstance(int argc, char *argv[], void **ih,
char * /* errbuf ATS_UNUSE
void
TSRemapDeleteInstance(void *ih)
{
- S3Config *s3 = static_cast<S3Config *>(ih);
- TSMutex s3_mutex_ptr = s3->config_reloader_mutex();
- TSMutexLock(s3_mutex_ptr);
- delete s3;
- TSMutexUnlock(s3_mutex_ptr);
+ S3Config *s3 = static_cast<S3Config *>(ih);
Review Comment:
Maybe, but the code to avoid the race condition has to modify s3 and then
fix the order of the destruction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
