masaori335 commented on code in PR #12341:
URL: https://github.com/apache/trafficserver/pull/12341#discussion_r2194337465
##########
src/iocore/hostdb/HostDB.cc:
##########
@@ -1294,6 +1294,10 @@ HostDBContinuation::remove_and_trigger_pending_dns()
}
EThread *thread = this_ethread();
while ((c = qq.dequeue())) {
+ if (c->action.cancelled || c->mutex == nullptr) {
Review Comment:
@bneradt your original fix of #9742 seems right.
Do you know where/how the `HostDBContinuation` is the queue is handled (or
cancelled) in other places?
##########
src/iocore/hostdb/HostDB.cc:
##########
@@ -1294,6 +1294,10 @@ HostDBContinuation::remove_and_trigger_pending_dns()
}
EThread *thread = this_ethread();
while ((c = qq.dequeue())) {
+ if (c->action.cancelled || c->mutex == nullptr) {
Review Comment:
@bneradt your original fix of #9742 seems right :)
Do you know where/how the `HostDBContinuation` is the queue is handled (or
cancelled) in other places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
