zwoop commented on code in PR #12363:
URL: https://github.com/apache/trafficserver/pull/12363#discussion_r2208831779
##########
plugins/header_rewrite/value.cc:
##########
@@ -55,6 +55,7 @@ Value::set_value(const std::string &val)
if (parser.parse_line(_value)) {
tcond_val->initialize(parser);
+ require_resources(tcond_val->get_resource_ids());
Review Comment:
Ok, as discussed on slack, I've made the code cleanup to make this less
confusing. There's no difference in behavior, just more clear as to why we have
to update the owners resource requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
