maskit commented on PR #12336:
URL: https://github.com/apache/trafficserver/pull/12336#issuecomment-3085840381

   Thank you for the report, and this PR. The code change you made on this PR 
helped me find a suspicious change.
   
   I haven't checked the actual behavior yet, but current code does seem to 
have an issue. `do_outbound_proxy_protocol` used to be called from 
`HttpSM::state_http_server_open` on `NET_EVENT_OPEN` event before  [this 
change](https://github.com/apache/trafficserver/commit/7d5e673309), but now 
it's called on `CONNECT_EVENT_TXN` event indirectly by 
`write_outbound_proxy_protocol`. I feel like `write_outbound_proxy_protocol` 
should be called on `CONNECT_EVENT_DIRECT` event as well.
   
   > i created a small PR for quick fix purposes only
   
   Would you update this PR if we provide you feedback?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to