bneradt commented on code in PR #12350:
URL: https://github.com/apache/trafficserver/pull/12350#discussion_r2223348357
##########
tests/CMakeLists.txt:
##########
@@ -91,10 +73,26 @@ add_custom_target(
autest_no_install
COMMAND ${RUNPIPENV} install
COMMAND
- ${CMAKE_COMMAND} -E env
PYTHONPATH=${CMAKE_CURRENT_SOURCE_DIR}/gold_tests/remap:$ENV{PYTHONPATH}
${RUNPIPENV} run
- env autest --directory ${CMAKE_CURRENT_SOURCE_DIR}/gold_tests
--ats-bin=${CMAKE_INSTALL_PREFIX}/bin
- --proxy-verifier-bin ${PROXY_VERIFIER_PATH} --build-root
${CMAKE_BINARY_DIR} --sandbox ${AUTEST_SANDBOX}
- ${CURL_UDS_FLAG} ${AUTEST_OPTIONS}
+ ${CMAKE_COMMAND} -E env
PYTHONPATH=${CMAKE_GOLD_DIR}/remap:$ENV{PYTHONPATH} ${RUNPIPENV} run env autest
--directory
+ ${CMAKE_GOLD_DIR} --ats-bin=${CMAKE_INSTALL_PREFIX}/bin
--proxy-verifier-bin ${PROXY_VERIFIER_PATH} --build-root
+ ${CMAKE_BINARY_DIR} --sandbox ${AUTEST_SANDBOX} ${CURL_UDS_FLAG}
${AUTEST_OPTIONS}
+ WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
+ USES_TERMINAL
+)
+
+# autest uds specific target that skips tests and runs with curl flag
+add_custom_target(
+ autest-uds
+ COMMAND ${CMAKE_COMMAND} --build ${CMAKE_BINARY_DIR} --target install
+ COMMAND ${RUNPIPENV} install
+ COMMAND ${CMAKE_COMMAND} -E rename ${CMAKE_GOLD_DIR}/h2
${CMAKE_SKIP_GOLD_DIR}/h2
+ COMMAND ${CMAKE_COMMAND} -E rename ${CMAKE_GOLD_DIR}/tls
${CMAKE_SKIP_GOLD_DIR}/tls
+ COMMAND
+ ${CMAKE_COMMAND} -E env
PYTHONPATH=${CMAKE_GOLD_DIR}/remap:$ENV{PYTHONPATH} ${RUNPIPENV} run env autest
--directory
+ ${CMAKE_GOLD_DIR} --ats-bin=${CMAKE_INSTALL_PREFIX}/bin
--proxy-verifier-bin ${PROXY_VERIFIER_PATH} --build-root
+ ${CMAKE_BINARY_DIR} --sandbox ${AUTEST_SANDBOX} ${CURL_UDS_FLAG}
${AUTEST_OPTIONS}
+ COMMAND ${CMAKE_COMMAND} -E rename {CMAKE_SKIP_GOLD_DIR}/h2
${CMAKE_GOLD_DIR}/h2
+ COMMAND ${CMAKE_COMMAND} -E rename ${CMAKE_SKIP_GOLD_DIR}/tls
${CMAKE_GOLD_DIR}/tls
Review Comment:
```
COMMAND ${CMAKE_COMMAND} -E rename ${CMAKE_GOLD_DIR}/h2
${CMAKE_SKIP_GOLD_DIR}/h2
COMMAND ${CMAKE_COMMAND} -E rename ${CMAKE_GOLD_DIR}/tls
${CMAKE_SKIP_GOLD_DIR}/tls
COMMAND
${CMAKE_COMMAND} -E env
PYTHONPATH=${CMAKE_GOLD_DIR}/remap:$ENV{PYTHONPATH} ${RUNPIPENV} run env autest
--directory
${CMAKE_GOLD_DIR} --ats-bin=${CMAKE_INSTALL_PREFIX}/bin
--proxy-verifier-bin ${PROXY_VERIFIER_PATH} --build-root
${CMAKE_BINARY_DIR} --sandbox ${AUTEST_SANDBOX} ${CURL_UDS_FLAG}
${AUTEST_OPTIONS}
COMMAND ${CMAKE_COMMAND} -E rename {CMAKE_SKIP_GOLD_DIR}/h2
${CMAKE_GOLD_DIR}/h2
COMMAND ${CMAKE_COMMAND} -E rename ${CMAKE_SKIP_GOLD_DIR}/tls
${CMAKE_GOLD_DIR}/tls
```
1. Two rename commands to move out of the way
2. Run the autests
3. Two rename commands to restore them back.
If the middle autest run fails, will the second set of renames that restore
the directories back be re-run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
