zwoop commented on code in PR #12377:
URL: https://github.com/apache/trafficserver/pull/12377#discussion_r2237946266


##########
include/cripts/Headers.hpp:
##########
@@ -199,21 +163,17 @@ class Header
     self_type &operator+=(const cripts::string_view str);
 
     // These specialized assignment operators all use the above
-    template <size_t N>
-    self_type &
-    operator=(const char (&str)[N])
-    {
-      return operator=(cripts::string_view(str, str[N - 1] ? N : N - 1));
-    }
+    // template <size_t N>
+    // self_type &
+    // operator=(const char (&str)[N])
+    //{
+    //  return operator=(cripts::string_view(str, str[N - 1] ? N : N - 1));
+    //}

Review Comment:
   So, I left it here, because at some point it was needed and useful, but it 
breaks some dependencies in this new code. Let me add a code here, for clarity.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to