cmcfarlen opened a new pull request, #12446: URL: https://github.com/apache/trafficserver/pull/12446
This moves the check for retry or not into the `VC_EVENT_EOS` case and no longer does a fall-through. Looking at the comment, it looks like the intent was to stop retrying when bytes were received, but neglected to handle the EOS case so the fall-through would unconditionally end retries. This is not the behavior from 9.2, which would retry here. This is certainly a funny edge-case in the protocol, and since we have sent the request to the server at this point, it is possible that the server has changed state and retries might not be bad. It seems more likely that we wrote the request to an already closed connection, so a retry should be fine. Since it's open to interpretation or situational, it might be something to add a config option for. For now though, I'd like to just restore the 9.2 behavior except in the case when we have received some bytes and the connection has closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
