Copilot commented on code in PR #12451: URL: https://github.com/apache/trafficserver/pull/12451#discussion_r2272006846
########## tools/hrw4u/src/script_common.py: ########## @@ -0,0 +1,145 @@ +#!/usr/bin/env python3 +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +"""Shared utilities for hrw4u and u4wrh scripts.""" + +from __future__ import annotations + +import argparse +import sys +from typing import Final, NoReturn, Protocol, TextIO, Any + +from antlr4 import CommonTokenStream, InputStream +from antlr4.error.ErrorStrategy import BailErrorStrategy + +from hrw4u.errors import Hrw4uSyntaxError, ThrowingErrorListener + +# Modern Python 3.11+ requirement +REQUIRED_PYTHON: Final[tuple[int, int]] = (3, 11) Review Comment: [nitpick] The Python version requirement is set to 3.11+ but the pyproject.toml shows Python 3.11+ as well. Consider if this high version requirement is necessary, as it may limit adoption. The comment mentions 'Modern Python 3.11+ requirement' but doesn't justify why 3.11 specifically is needed. ```suggestion # Modern Python 3.9+ requirement REQUIRED_PYTHON: Final[tuple[int, int]] = (3, 9) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
