bneradt commented on code in PR #12449:
URL: https://github.com/apache/trafficserver/pull/12449#discussion_r2277750197


##########
src/api/InkAPITest.cc:
##########
@@ -917,9 +917,11 @@ synserver_vc_accept(TSCont contp, TSEvent event, void 
*data)
   TSAssert(s->magic == MAGIC_ALIVE);
 
   if (event == TS_EVENT_NET_ACCEPT_FAILED) {
-    Warning("Synserver failed to bind to port %d.", ntohs(s->accept_port));
-    ink_release_assert(!"Synserver must be able to bind to a port, check 
system netstat");
-    Dbg(dbg_ctl_SockServer, "%s: NET_ACCEPT_FAILED", __func__);
+    if (s && s->accept_port != SYNSERVER_DUMMY_PORT) {

Review Comment:
   I was a little concerned about this happening to match in production, but 
then noticed SYNSERVER_DUMMY_PORT is -1. :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to