JakeChampion commented on PR #12407: URL: https://github.com/apache/trafficserver/pull/12407#issuecomment-3248565504
> Looks good. You might be fixing an issue commented in the autests too. Can you please try running with this applied to your patch: > > ```diff > diff --git a/tests/gold_tests/logging/log-filenames.test.py b/tests/gold_tests/logging/log-filenames.test.py > index a4fdbc73b..ec6e8928a 100644 > --- a/tests/gold_tests/logging/log-filenames.test.py > +++ b/tests/gold_tests/logging/log-filenames.test.py > @@ -257,11 +257,4 @@ class stderrTest(LogFilenamesTest): > DefaultNamedTest() > CustomNamedTest() > stdoutTest() > - > -# The following stderr test can be run successfully by hand using the replay > -# files from the sandbox. All the expected output goes to stderr. However, for > -# some reason during the AuTest run, the stderr output stops emitting after the > -# logging.yaml file is parsed. This is left here for now because it is valuable > -# for use during development, but it is left commented out so that it doesn't > -# produce the false failure in CI and developer test runs. > -# stderrTest() > +stderrTest() > ``` > > That patch works fine for me locally with or without your patch, but I wonder whether it's related to what you are fixing. I pushed that patch up, the tests passed with it ☺️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
